User doesn't need the third KPI tile. Drop it from the markup, drop
the matching #totalGesamtProvision write in updateProvisionenTable
and let the grid breathe with two columns instead of three. Revert
the backend total_gesamt_provision field to its original meaning
(shop + employee) since no consumer in the UI depends on it now.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Gesamt-Provision represents what the shop keeps after paying the
employee, not the sum of both. Update both the frontend KPI card
calculation and the /api/provisionen total_gesamt_provision field so
they agree.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- New nullable anbieter.default_vo_id column (migration adds it to
existing DBs); deleting a VO that some provider points at clears
the reference automatically.
- GET /api/anbieter now includes default_vo_id + default_vo_nummer
+ default_vo_bezeichnung so the wizard can preselect without an
extra round-trip.
- New PUT /api/anbieter/:id/default-vo endpoint. Validates the VO
belongs to the given provider; accepts vo_id=null to clear.
- VO admin table grew a "Standard" column and an "Als Standard" /
"Standard entfernen" button on each row.
- When the user picks a provider in step 1 of the wizard, the VO
dropdown now preselects the default VO (falling back to the only
VO if there is exactly one), and immediately loads the
matching tariffs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
VOs (Vertriebspartner-Nummern)
- New vos table (one row per VO, scoped to a provider). Migrations
add tarife.vo_id and schaltungen.vo_id columns (nullable so legacy
rows survive).
- New /api/vos CRUD (list, create, update, delete with use-checks).
- Admin: new "VOs (Vertriebspartner)" sub-tab. List/create with
provider dropdown; edit via prompt; delete refuses while used.
- /api/tarife?vo_id=X filter for fetching tariffs of a specific VO.
Tariff editor
- Add-tariff form requires a VO; new dependent VO dropdown that
populates after the provider is chosen.
- Edit-tariff modal now shows the VO dropdown and a checkbox grid of
all anbieter-wide tarifoptionen. Saving the dialog applies the
selection via the existing tarifoptionen_tarife table.
- New GET /api/tarife/:id/tarifoptionen-multi returns the option set
scoped to the tariff's provider, each annotated with whether it is
currently assigned to this tariff.
- POST/PUT /api/tarife accept vo_id (required for create, validated
against the provider) and an optional tarifoption_ids array.
Schaltung wizard
- The Schaltung-erfassen tab is now a 2-step wizard:
step 1 picks a provider from a button row (mirrors the screenshot
the user shared); step 2 shows a 2-column form mirroring the
Aktivierungs-/Vertragsdaten layout.
- Step 2 cascades: VO -> tariffs filtered by VO -> tarifoptionen
filtered by tariff. Erfasser is autofilled from the logged-in user
(read-only).
- Removed customer fields that the user does not need (Kundennummer,
Kennwort/Service-PIN never existed; Rufnummer is now optional both
in the form and in the API validation).
- After saving, the wizard resets to step 1 ready for the next entry.
Schema
- tarife: vo_id added.
- schaltungen: vo_id added; rufnummer is nullable in new DBs.
Existing DBs may still have NOT NULL on rufnummer; the schaltungen
route now sends an empty string instead of NULL to remain
compatible.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Backend
- New routes/users.js (admin-only via requireAdmin) with list, create,
update (incl. password reset) and delete endpoints.
- All user-facing API responses identify users by uuid, not the
numeric primary key — usernames can now be renamed without breaking
external references.
- Protection rules: cannot delete or demote the last admin; cannot
delete or demote your own account.
Schema / data
- users table gained a uuid TEXT column (unique). Existing rows are
backfilled with crypto.randomUUID() on startup. Setup endpoint and
the create-user CLI both generate a UUID for new users.
Frontend
- New "Benutzer" tab in nav-tabs, marked admin-only and shown only
after /api/auth/me reports isAdmin.
- Modal with create / edit forms (password optional on edit = leave
unchanged). XSS-safe rendering of the user list using the existing
escapeHtml helper and data-* attributes for action buttons.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Bug fixes
- Sync database.js schema with actual production DB (tarifoptionen
shape was wrong; new installs would have broken).
- Fix SQL syntax error `SELECT to.*` (reserved keyword) in single-
schaltung provision endpoint, plus the dead fallback hierarchy
that selected columns that were never in the query.
- Fix PUT /api/tarifoptionen/:id writing to non-existent column
provision_betrag (should be provision_euro).
- Fix race condition in PUT /api/schaltungen/:id where forEach with
async db.run inside a transaction could send duplicate responses.
- Delete dokumente rows explicitly before deleting schaltung
(existing DBs lack ON DELETE CASCADE on dokumente FK).
- Replace hardcoded basisBetrag=100 for percent rules; basis is now
configurable per rule via the new basis_euro column.
Security
- Multi-user authentication: users table, bcryptjs, express-session
with SQLite store, login/logout/me/setup/change-password endpoints.
- Auth gate on all /api/* except /api/auth/*.
- CLI to create users: npm run create-user -- <user> <pass> [--admin].
- helmet for security headers.
- CORS restricted to ALLOWED_ORIGINS env (default same-origin).
- Rate limits: 300/min global, 20/15min on login.
- Path-traversal validation on document download/delete.
- XSS hardening in frontend: escapeHtml helper applied to all
DB-derived innerHTML interpolations; inline onclick handlers that
embedded user-controlled strings replaced with data-* attrs +
addEventListener.
Architecture
- Provision calculation centralised in provisionService.js as the
single source of truth (was duplicated and inconsistent).
- server.js cut from 2138 to ~140 lines; routes split into per-
resource modules under routes/.
- Promise wrapper db.js for sqlite3 callbacks; async/await in routes.
- middleware/ for auth and async error handling.
Tests
- 14 unit tests for provisionService covering fallback hierarchy,
percent calculation, tarifoptionen, hardware logic, employee
commission. All green.
Config
- dotenv loads .env.local at startup (gitignored).
- .gitignore extended for sessions.db and .env*.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
kerimatilganandClaude Opus 4.7